Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add lock on qcc to fix sync issue #814

Merged
3 commits merged into from
Nov 30, 2023
Merged

add lock on qcc to fix sync issue #814

3 commits merged into from
Nov 30, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2023 •
edited by ghost
Loading

Description

fix for sdk issue 755: Intermittent exception with query context cache

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@ghost ghost self-requested a review as a code owner November 17, 2023 19:01
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited
Loading

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (62f2206) 83.56% compared to head (3c3cce3) 83.41%.

Files Patch % Lines
Snowflake.Data/Core/QueryContextCache.cs 82.92% 5 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
- Coverage   83.56%   83.41%   -0.15%     
==========================================
  Files          89       89              
  Lines        9155     9173      +18     
  Branches      837      839       +2     
==========================================
+ Hits         7650     7652       +2     
- Misses       1275     1290      +15     
- Partials      230      231       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost ghost force-pushed the SNOW-971927-exception-with-qcc branch from afae0fb to b9d20f4 Compare November 18, 2023 00:43
@ghost ghost requested a review from sfc-gh-mhofman November 18, 2023 01:08
@sfc-gh-knozderko sfc-gh-knozderko self-requested a review November 21, 2023 11:37
@ghost ghost merged commit 2dce725 into master Nov 30, 2023
20 of 22 checks passed
@ghost ghost deleted the SNOW-971927-exception-with-qcc branch November 30, 2023 20:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-knozderko @sfc-gh-mhofman @sfc-gh-ext-simba-hx